Add HRA uterus NTR batch outputs and review reports#3723
Conversation
Generated via bulk_ntr_workflow from source_data/uterus.csv (BOM header normalized into source_data/uterus_only.csv for processing). Pipeline completed through Stage 4: - 27 new UBERON leaf terms in final template - 0 group terms - 6 confirmed existing matches excluded - 0 possible matches identified - 0 out-of-scope terms - 1 manual-curation item QC status: - 0 [PENDING] definitions - 0 INFER/UNRESOLVABLE/NEEDS_MAPPING markers Includes: - Source data snapshots in bulk_ntr_workflow/source_data/ - Template and groups TSVs in src/templates/ - Review reports: candidates, errors, input, manual_curation Signed-off-by: @dragon-ai-agent
|
Claude finished @zhengj2007's task in 6m 25s —— View job PR Review: Add HRA uterus NTR batch outputs and review reportsTasks:
Review submitted: REQUEST_CHANGESReview checklist:
🔴 CRITICAL — Must fix before merge1. Six terms have ROBOT will fail or produce invalid OWL when it encounters the literal string The pipeline could not find a UBERON ID for the parent "lower uterine segment" at processing time — but
🟡 IMPORTANT — Should fix before merge2. Verify PMID:42152375 and PMID:42116181 — used for 3. 🔵 SUGGESTIONS — Optional
What looks good ✅
|
There was a problem hiding this comment.
Review checklist
- Hierarchy and parents are consistent — PARTIAL: most parent IDs valid; 6 terms have
UNKNOWN(see below) - Definitions and supporting references look adequate — PARTIAL: PMID:42152375, PMID:42116181 need verification
- Obsolete or replacement handling is safe — no obsoletions in this PR
- OBO and ODK conventions appear preserved — template format correct; ID range 8930000–8931000 is properly allocated to Jie Zheng
- No obvious CI, auth, or workflow regression — no workflow files touched
Summary
This batch adds 27 new UBERON leaf terms for uterus anatomy via the HRA NTR pipeline. The overall structure is well-organised, the FMA:17561 → UBERON:1200003 parent mapping for fundus terms was resolved correctly, and 6 confirmed existing terms were appropriately excluded. However, there are blocking issues that need to be resolved before the template can be processed by ROBOT.
🔴 CRITICAL — Must fix before merge
1. Six terms have UNKNOWN in both is_a and part_of columns ()
ROBOT will fail or produce invalid OWL when it encounters the literal string UNKNOWN as a class IRI. The six affected terms are the left/right/central anterior/posterior subdivisions of the lower uterine segment:
| Term | UBERON ID | Row |
|---|---|---|
| central anterior lower uterine segment | UBERON_8930202 | row 5 |
| central posterior lower uterine segment | UBERON_8930205 | row 8 |
| left anterior lower uterine segment | UBERON_8930220 | row 16 |
| left posterior lower uterine segment | UBERON_8930223 | row 19 |
| right anterior lower uterine segment | UBERON_8930229 | row 25 |
| right posterior lower uterine segment | UBERON_8930232 | row 28 |
The pipeline flagged these in ("unknown_parent" — no UBERON ID for parent label "lower uterine segment") but left the parent as rather than resolving it. The parent term ** (UBERON:8930224)** is defined in this same template batch. The fix is to set:
- → (zone of organ)
- → (lower uterine segment — the new term also in this template)
🟡 IMPORTANT — Should fix before merge
2. Verify PMID:42152375 and PMID:42116181
These are used as the sole publication references (beyond the ASCTB-TEMP placeholder) for:
- (UBERON_8930210)
- (UBERON_8930225)
PMIDs in the 42-million range are plausible for 2025 publications, but they should be explicitly verified as real indexed papers with content relevant to the uterine serosa. If they cannot be confirmed, alternative references should be found.
3. Parent of is too broad
(UBERON_8930224, row 20) has (uterus). Anatomically the lower uterine segment is a sub-region of the body of uterus (UBERON:0009853), which is itself part of the uterus. Using would be more precise and consistent with how the body-of-uterus terms in this same batch are handled.
🔵 SUGGESTIONS — Optional improvements
4. Genus specificity for myometrium layers
(UBERON_8930216) and (UBERON_8930226) use (organ part). A more specific genus — (zone of organ) — would be consistent with how the positional uterus-body/fundus/lower-segment terms are typed in this same batch.
5. Preprint reference for outer uterine myometrium
(UBERON_8930226) includes a bioRxiv preprint DOI () as a def_xref. This is not critical since the term also cites PMID:20551073 and PMID:32427986, but prefer published references where possible.
6. Stage 5 (template registration) not yet run
The script (Stage 5 of the workflow) has not been run to register the new templates in . If this is intentional (e.g., registration is a follow-up step), please note it explicitly in the PR description.
What is fine ✅
- ID range is correctly allocated to Jie Zheng in
- FMA:17561 → UBERON:1200003 (uterine fundus) mapping resolved correctly for all 8 fundus sub-terms; UBERON:1200003 confirmed to exist in the ontology
- All other and parent IDs confirmed present: UBERON:0034944, UBERON:0009853, UBERON:1200003, UBERON:0002384, UBERON:0001136, UBERON:0003891, UBERON:0012249, UBERON:0000458, UBERON:0001638, UBERON:0000995, UBERON:0000064, UBERON:0001296, UBERON:0001297
- correctly routed to and excluded from the ROBOT template (it belongs in CL, not UBERON)
- 6 confirmed existing terms correctly excluded in
- Template column directives, subset IRI, ORCID, NCBITaxon, and date format all look correct
- is empty (no group terms in this batch), which is consistent with the pipeline report
There was a problem hiding this comment.
Review checklist
- Hierarchy and parents are consistent — PARTIAL: most parent IDs valid; 6 terms have
UNKNOWN(see below) - Definitions and supporting references look adequate — PARTIAL: PMID:42152375, PMID:42116181 need verification
- Obsolete or replacement handling is safe — no obsoletions in this PR
- OBO and ODK conventions appear preserved — template format correct; ID range 8930000-8931000 is properly allocated to Jie Zheng
- No obvious CI, auth, or workflow regression — no workflow files touched
Summary
This batch adds 27 new UBERON leaf terms for uterus anatomy via the HRA NTR pipeline. The overall structure is well-organised, the FMA:17561 to UBERON:1200003 parent mapping for fundus terms was resolved correctly, and 6 confirmed existing terms were appropriately excluded. However, there are blocking issues that need to be resolved before the template can be processed by ROBOT.
CRITICAL — Must fix before merge
1. Six terms have UNKNOWN in both is_a and part_of columns
File: src/templates/hra-uterus.template.tsv
ROBOT will fail or produce invalid OWL when it encounters the literal string UNKNOWN as a class IRI. The six affected terms are the left/right/central anterior/posterior subdivisions of the lower uterine segment:
| Term | UBERON ID | Row |
|---|---|---|
| central anterior lower uterine segment | UBERON_8930202 | row 5 |
| central posterior lower uterine segment | UBERON_8930205 | row 8 |
| left anterior lower uterine segment | UBERON_8930220 | row 16 |
| left posterior lower uterine segment | UBERON_8930223 | row 19 |
| right anterior lower uterine segment | UBERON_8930229 | row 25 |
| right posterior lower uterine segment | UBERON_8930232 | row 28 |
The pipeline flagged these in errors.tsv ("unknown_parent" — no UBERON ID found for parent label "lower uterine segment") but left the parent as UNKNOWN rather than resolving it. The parent term lower uterine segment (UBERON:8930224) is defined in this same template batch. The fix is to set:
is_acolumn:UBERON:0034944(zone of organ)part_ofcolumn:http://purl.obolibrary.org/obo/UBERON_8930224(lower uterine segment — the new term also in this template)
IMPORTANT — Should fix before merge
2. Verify PMID:42152375 and PMID:42116181
These are used as the sole publication references (beyond the ASCTB-TEMP placeholder) for:
connective tissue of the uterine serosa(UBERON_8930210)mesothelium of the uterine serosa(UBERON_8930225)
PMIDs in the 42-million range are plausible for 2025 publications, but they should be explicitly verified as real indexed papers with content relevant to the uterine serosa. If they cannot be confirmed, alternative references should be found.
3. Parent of lower uterine segment is too broad
lower uterine segment (UBERON_8930224, row 20) has part_of: UBERON:0000995 (uterus). Anatomically the lower uterine segment is a sub-region of the body of uterus (UBERON:0009853), which is itself part of the uterus. Using part_of: UBERON:0009853 would be more precise and consistent with how the body-of-uterus terms in this same batch are handled.
SUGGESTIONS — Optional improvements
4. Genus specificity for myometrium layers
inner uterine myometrium (UBERON_8930216) and outer uterine myometrium (UBERON_8930226) use is_a: UBERON:0000064 (organ part). A more specific genus — UBERON:0034944 (zone of organ) — would be consistent with how the positional uterus-body/fundus/lower-segment terms are typed in this same batch.
5. Preprint reference for outer uterine myometrium
outer uterine myometrium (UBERON_8930226) includes a bioRxiv preprint DOI (https://doi.org/10.1101/2021.01.02.425073) as a def_xref. This is not critical since the term also cites PMID:20551073 and PMID:32427986, but published references are preferred.
6. Stage 5 (template registration) not yet run
The register_templates.py script (Stage 5 of the workflow) has not been run to register the new templates in uberon-odk.yaml. If this is intentional (e.g., registration is a follow-up step), please note it explicitly in the PR description.
What looks good
- ID range
UBERON:8930xxxis correctly allocated to Jie Zheng inuberon-idranges.owl - FMA:17561 to UBERON:1200003 (uterine fundus) mapping resolved correctly for all 8 fundus sub-terms; UBERON:1200003 confirmed to exist in the ontology
- All other parent IDs confirmed present: UBERON:0034944, UBERON:0009853, UBERON:1200003, UBERON:0002384, UBERON:0001136, UBERON:0003891, UBERON:0012249, UBERON:0000458, UBERON:0001638, UBERON:0000995, UBERON:0000064, UBERON:0001296, UBERON:0001297
columnar cell of endocervixcorrectly routed tomanual_curation.tsvand excluded from the ROBOT template (belongs in CL, not UBERON)- 6 confirmed existing terms correctly excluded in
candidates.tsv - Template column directives, subset IRI, ORCID, NCBITaxon, and date format all look correct
hra-uterus-groups.template.tsvis empty (no group terms), consistent with the pipeline report
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
Reports are review artifacts, not ODK templates, and should not live under src/templates/. Relocated to bulk_ntr_workflow/outputs/ to match the canonical layout used by the muscular branch (PR #3700). Signed-off-by: dragon-ai-agent
|
Reports relocated. Route: ODK-register (~29 terms ≥20). TODO: build component + register in Automated update (@cellsemantic / dragon-ai-agent, for @dosumis). Reports were relocated out of |
|
Claude finished @dosumis's task in 2m 52s —— View job PR Review: Add HRA uterus NTR batch outputs and review reportsTasks:
Review submitted: REQUEST_CHANGESReview checklist:
The two commits since the last full review ( 🔴 CRITICAL — Must fix before merge1. Six terms still have
ROBOT will fail (or produce a broken class) on the literal string
🟡 IMPORTANT — Should fix before merge2. PMID:42152375 / PMID:42116181 still unverified Used for 3.
4. Stage 5 registration not done — required per new batch-size policy Per the 2026-07-09 routing comment, batches ≥20 new terms (this one has 27) go through ODK-register: 🔵 SUGGESTIONS — Optional
What looks good ✅
Note: I don't have web/literature-search tool access in this run, so item #2 (PMID verification) could not be independently confirmed — flagging so a reviewer with that access can check before merge. |
This PR modifies some logical definitions. See details below:Number of classes with modified logical definitions: 1 gABAergic systemNo changes in inferred subclasses. |
There was a problem hiding this comment.
Review checklist
- Hierarchy and parents are consistent — PARTIAL: 6 terms still have literal
UNKNOWNinis_a/part_of - Definitions and supporting references look adequate — PARTIAL: PMID:42152375 / PMID:42116181 unverified
- Obsolete or replacement handling is safe — no obsoletions in this PR
- OBO and ODK conventions appear preserved — Stage 5 (ODK-register) not yet done; required per batch-size policy for this ≥20-term batch
- No obvious CI, auth, or workflow regression
Summary
This is a re-review after the report-relocation commit (f82ed04). That commit only moved report artifacts from src/templates/ to bulk_ntr_workflow/outputs/hra-uterus-reports/; the template content itself is unchanged, so the previously-flagged critical issue remains.
🔴 CRITICAL: src/templates/hra-uterus.template.tsv rows 5, 8, 16, 19, 25, 28 (UBERON_8930202/8930205/8930220/8930223/8930229/8930232 — the six anterior/posterior lower-uterine-segment subdivisions) have literal UNKNOWN in both is_a and part_of. ROBOT will fail on this. Fix: is_a → UBERON:0034944 (zone of organ), part_of → UBERON:8930224 (lower uterine segment, defined in this same template).
🟡 IMPORTANT:
- PMID:42152375 and PMID:42116181 (used for the uterine serosa connective-tissue/mesothelium terms) still need verification as real, indexed, on-topic papers.
lower uterine segment(UBERON_8930224) usespart_of: UBERON:0000995(uterus) rather than the more preciseUBERON:0009853(body of uterus) used by sibling terms in this batch.- Per the 2026-07-09 routing comment, batches ≥20 new terms require ODK-register (component +
uberon-odk.yaml/Makefile/catalog). Confirmed none of these currently referencehra-uterus— Stage 5 (register_templates.py) has not been run.
🔵 Suggestion: myometrium terms could use UBERON:0034944 (zone of organ) instead of UBERON:0000064 (organ part) for consistency with sibling terms.
Full details posted in the PR conversation comment.
Signed, @dragon-ai-agent
- Build and commit components/hra_uterus.owl from the ROBOT template - Add hra-uterus-prefixes.owl, catalog redirect, uberon-odk.yaml entry, Makefile rule, and uberon-edit.obo import (leaf template only) - Resolve 6 UNKNOWN parents on the '* lower uterine segment' terms: is_a zone of organ (UBERON:0034944), part_of lower uterine segment (UBERON:8930224), mirroring the sibling body/fundus subdivisions - Remove empty hra-uterus-groups.template.tsv (0 rows); reserialise edit file Signed-off-by: dragon-ai-agent
|
ODK wiring completed & pushed. Registered as an ODK component (≥20 → register): built/committed
Also: CI will now actually load the component and run the reasoner + taxon-constraint checks on these terms for the first time — watch for any unsatisfiability/taxon issues that surface from the content (couldn't run the full reasoner locally without Docker). Automated update (@cellsemantic / dragon-ai-agent, for @dosumis). |
|
Claude finished @dosumis's task in 3m 18s —— View job PR Review: Add HRA uterus NTR batch outputs and review reportsTasks:
Review submitted: REQUEST_CHANGESReview checklist:
What changed since the last review (commit
|
| http://purl.obolibrary.org/obo/UBERON_8930221 left posterior body of uterus The region of the body of uterus that is located on the left side of the posterior aspect of the uterine corpus, above the isthmus and below the orifices of the uterine tubes. https://purl.org/ccf/ASCTB-TEMP_left-posterior-body-of-uterus|PMID:29262069 UBERON:0034944 UBERON:0009853 http://purl.obolibrary.org/obo/uberon/core#added_by_HRA 2026-05-26T00:00:00Z https://orcid.org/0000-0002-2999-0103 http://purl.obolibrary.org/obo/NCBITaxon_9606 Wikipedia:Uterus | ||
| http://purl.obolibrary.org/obo/UBERON_8930222 left posterior fundus of uterus A zone of organ that is located in the left lateral posterior region of the superior dome-shaped portion of the uterus, on the dorsal aspect of the left side of the uterine fundus. https://purl.org/ccf/ASCTB-TEMP_left-posterior-fundus-of-uterus|PMID:32567320 UBERON:0034944 UBERON:1200003 http://purl.obolibrary.org/obo/uberon/core#added_by_HRA 2026-05-26T00:00:00Z https://orcid.org/0000-0002-2999-0103 http://purl.obolibrary.org/obo/NCBITaxon_9606 Wikipedia:Uterus | ||
| http://purl.obolibrary.org/obo/UBERON_8930223 left posterior lower uterine segment A zone of organ that is located in the left lateral posterior region of the lower uterine segment, the narrowing transitional area between the uterine body and cervix on the dorsal left side. https://purl.org/ccf/ASCTB-TEMP_left-posterior-lower-uterine-segment|PMID:13131157|PMID:27342045 UBERON:0034944 UBERON:8930224 http://purl.obolibrary.org/obo/uberon/core#added_by_HRA 2026-05-26T00:00:00Z https://orcid.org/0000-0002-2999-0103 http://purl.obolibrary.org/obo/NCBITaxon_9606 Wikipedia:Uterus | ||
| http://purl.obolibrary.org/obo/UBERON_8930224 lower uterine segment A zone of the uterus that forms the inferior portion of the uterine body, located between the anatomic internal os and the uterine fundus, which becomes particularly distinct during pregnancy and labor. https://purl.org/ccf/ASCTB-TEMP_lower-uterine-segment|PMID:13131157|PMID:27342045 UBERON:0034944 UBERON:0000995 http://purl.obolibrary.org/obo/uberon/core#added_by_HRA 2026-05-26T00:00:00Z https://orcid.org/0000-0002-2999-0103 http://purl.obolibrary.org/obo/NCBITaxon_9606 |
There was a problem hiding this comment.
🟡 IMPORTANT: lower uterine segment (UBERON:8930224) uses part_of: UBERON:0000995 (uterus). The six * lower uterine segment subdivisions in this same template (rows 5, 8, 16, 19, 25, 28) — and all the sibling body-of-uterus terms (e.g. row 3 central anterior body of uterus) — use part_of: UBERON:0009853 (body of uterus). Since the lower uterine segment is anatomically the inferior sub-region of the uterine body, UBERON:0009853 would be more precise and consistent, and would also propagate correctly to the six child terms that are part_of this term.
| http://purl.obolibrary.org/obo/UBERON_8930203 central posterior body of uterus The region of the body of uterus that is located along the midline on the posterior aspect of the uterine corpus, above the isthmus and below the orifices of the uterine tubes. https://purl.org/ccf/ASCTB-TEMP_central-posterior-body-of-uterus|PMID:29262069 UBERON:0034944 UBERON:0009853 http://purl.obolibrary.org/obo/uberon/core#added_by_HRA 2026-05-26T00:00:00Z https://orcid.org/0000-0002-2999-0103 http://purl.obolibrary.org/obo/NCBITaxon_9606 Wikipedia:Uterus | ||
| http://purl.obolibrary.org/obo/UBERON_8930204 central posterior fundus of uterus A zone of organ that is located in the medial posterior region of the superior dome-shaped portion of the uterus, positioned dorsal to the midline of the uterine fundus. https://purl.org/ccf/ASCTB-TEMP_central-posterior-fundus-of-uterus|PMID:32567320 UBERON:0034944 UBERON:1200003 http://purl.obolibrary.org/obo/uberon/core#added_by_HRA 2026-05-26T00:00:00Z https://orcid.org/0000-0002-2999-0103 http://purl.obolibrary.org/obo/NCBITaxon_9606 Wikipedia:Uterus | ||
| http://purl.obolibrary.org/obo/UBERON_8930205 central posterior lower uterine segment A zone of organ that is located in the medial posterior region of the lower uterine segment, the narrowing transitional area between the uterine body and cervix that becomes more prominent during late pregnancy. https://purl.org/ccf/ASCTB-TEMP_central-posterior-lower-uterine-segment|PMID:13131157|PMID:27342045 UBERON:0034944 UBERON:8930224 http://purl.obolibrary.org/obo/uberon/core#added_by_HRA 2026-05-26T00:00:00Z https://orcid.org/0000-0002-2999-0103 http://purl.obolibrary.org/obo/NCBITaxon_9606 Wikipedia:Uterus | ||
| http://purl.obolibrary.org/obo/UBERON_8930210 connective tissue of the uterine serosa A portion of connective tissue that is part of a serosa of uterus. This connective tissue layer underlies the mesothelium and forms the structural component of the perimetrium. https://purl.org/ccf/ASCTB-TEMP_connective-tissue-of-the-uterine-serosa|PMID:42152375|PMID:42116181 UBERON:0002384 UBERON:0001297 http://purl.obolibrary.org/obo/uberon/core#added_by_HRA 2026-05-26T00:00:00Z https://orcid.org/0000-0002-2999-0103 http://purl.obolibrary.org/obo/NCBITaxon_9606 Wikipedia:Perimetrium |
There was a problem hiding this comment.
🟡 IMPORTANT: PMID:42152375 and PMID:42116181 (also used on row 21, mesothelium of the uterine serosa) are in a very high PMID range consistent only with papers indexed in the last few months. I don't have literature-lookup/web-search tool access in this run (permission was not granted), so I could not independently verify these are real, indexed, topically-relevant papers on the uterine serosa. This has been flagged in every review of this PR since 2026-05-26 and remains unconfirmed — please have a reviewer with PubMed/Europe PMC access verify before merge, or swap in confirmed references.
There was a problem hiding this comment.
Review checklist
- Hierarchy and parents are consistent — the 6
UNKNOWNis_a/part_ofvalues reported in every prior review are now resolved (rows 5, 8, 16, 19, 25, 28 →is_a UBERON:0034944zone of organ,part_of UBERON:8930224lower uterine segment). One precision issue remains (see below). - Definitions and supporting references look adequate — PMID:42152375 / PMID:42116181 still unverified (no literature-lookup tool access in this run; flagged since 2026-05-26)
- Obsolete or replacement handling is safe — no obsoletions in this PR
- OBO and ODK conventions appear preserved —
hra_uterusis now registered as an ODK component (uberon-odk.yaml,uberon.Makefile,catalog-v001.xml,uberon-edit.oboimport), mirroring the existinghra_skeletoncomponent exactly. Emptyhra-uterus-groups.template.tsvwas correctly removed. - No obvious CI, auth, or workflow regression — no
.github/.claudefiles touched; CI build/reasoner run was still in progress at review time
Summary
This is a re-review after the Register hra_uterus as ODK component commit (30d1ad3). The previously blocking issue is fixed:
✅ Resolved: The 6 terms that had literal UNKNOWN in is_a/part_of (central/left/right anterior/posterior lower uterine segment) now correctly reference UBERON:0034944 (zone of organ) and UBERON:8930224 (lower uterine segment, defined in the same batch). Confirmed zero remaining UNKNOWN occurrences in src/templates/hra-uterus.template.tsv.
✅ Resolved: Per the batch-size policy (≥20 new terms → ODK-register), hra_uterus is now wired up as a proper ODK component — components/hra_uterus.owl (386 lines, 27 classes), hra-uterus-prefixes.owl, uberon-odk.yaml entry, uberon.Makefile rule, catalog redirect, and edit-file import all present and consistent with the pre-existing hra_skeleton component pattern.
🟡 Still open: lower uterine segment (UBERON:8930224) uses part_of: UBERON:0000995 (uterus) rather than UBERON:0009853 (body of uterus), which is what every sibling body-of-uterus term in this batch uses. Since the six lower-uterine-segment subdivisions inherit their location via part_of this term, tightening this to UBERON:0009853 would improve precision throughout. See inline comment.
🟡 Still open: PMID:42152375 and PMID:42116181 (used for the two uterine-serosa terms) remain unverified — I don't have web/literature-search tool permissions in this environment. This has been flagged in every review since 2026-05-26. Please have a reviewer with PubMed/Europe PMC access confirm these are real, indexed, on-topic papers before merge.
🔵 Suggestion (unchanged, optional): inner/outer uterine myometrium use is_a: UBERON:0000064 (organ part) rather than UBERON:0034944 (zone of organ), which would be more consistent with the other positional terms in this batch.
Requesting changes only for the two 🟡 items above — the previously-blocking critical issue is fixed. Once the PMIDs are confirmed and the lower uterine segment parent is (optionally) tightened, this looks ready to merge.
Runs 'odk.py update' (ODK v1.6.1) so the generated src/ontology/Makefile includes hra_uterus.owl in OTHER_SRC with stamp-component target and default rule; the prefixes override in uberon.Makefile applies on top. Incidental update_repo byproducts reverted. Signed-off-by: dragon-ai-agent
|
Claude finished @dosumis's task in 5m 11s —— View job PR Review: Add HRA uterus NTR batch outputs and review reportsTasks:
Review submitted: REQUEST_CHANGESReview checklist:
What changed since the last review (new commit
|
There was a problem hiding this comment.
Review checklist
- Hierarchy and parents are consistent — the 6 previously-
UNKNOWNrows remain correctly resolved (is_a UBERON:0034944,part_of UBERON:8930224); one precision issue remains open - Definitions and supporting references look adequate — PMID:42152375 / PMID:42116181 still unverified
- Obsolete or replacement handling is safe — no obsoletions in this PR
- OBO and ODK conventions appear preserved — new commit
48dee58regeneratessrc/ontology/Makefilecleanly, mirrorshra_skeletonpattern exactly - No obvious CI, auth, or workflow regression
Summary
Re-review after commit 48dee58 ("Regenerate ODK Makefile to wire hra_uterus component"). I diffed this commit directly: it touches only src/ontology/Makefile, adding hra_uterus.owl to OTHER_SRC, the recreate-components stamp lists, and a default template rule — mirroring the pre-existing hra_skeleton entries line-for-line. Since Makefile includes uberon.Makefile, the prefix-aware override rule already present there correctly takes precedence. No regression.
I independently re-confirmed: zero remaining UNKNOWN in src/templates/hra-uterus.template.tsv; components/hra_uterus.owl contains exactly 27 unique classes with no UNKNOWN; uberon-odk.yaml/catalog-v001.xml/uberon-edit.obo wiring all mirror hra_skeleton exactly.
🟡 IMPORTANT — still open:
- PMID:42152375 and PMID:42116181 (uterine serosa connective-tissue/mesothelium terms, rows 9 and 21) remain unverified. I attempted verification via Europe PMC (artl-mcp), WebFetch, and WebSearch in this run — all three were denied by permissions in this environment. Flagged in every review since 2026-05-26; please have a reviewer with literature-lookup access confirm before merge.
lower uterine segment(UBERON:8930224, row 20) still usespart_of: UBERON:0000995(uterus) rather thanUBERON:0009853(body of uterus), which every sibling body-of-uterus term in this batch uses. This propagates to the 6 subdivision terms that arepart_ofthis term.
🔵 Suggestion (optional, unchanged): inner/outer uterine myometrium use is_a: UBERON:0000064 (organ part) rather than UBERON:0034944 (zone of organ), for consistency with sibling positional terms.
Note: the CI workflow run for this push was still in progress at review time, so full reasoner/taxon-constraint results on the newly-loaded component weren't yet available to cross-check.
Requesting changes only for the two 🟡 items above — the ODK wiring and previously-critical UNKNOWN issue remain resolved and clean.
Signed, @dragon-ai-agent
|
Correction re: Makefile. My earlier note said I "added a Makefile rule" — that was a manual edit to Incidental Automated update (@cellsemantic / dragon-ai-agent, for @dosumis). |
Generated via bulk_ntr_workflow from source_data/uterus.csv (BOM header normalized into source_data/uterus_only.csv for processing).
Pipeline completed through Stage 4:
QC status:
Includes:
Signed-off-by: @dragon-ai-agent