Little typo fix of unordered list#1469
Open
AlexanderSerbul wants to merge 2 commits into
Open
Conversation
Owner
|
Hi. Thanks for this. We usually use - for unordered lists (including in this file). Is there a reason you used * instead? Also, would you mind retargeting at the dev branch? |
Author
Hi, no reason to use "*" instead of "-", of course. Changed target to the dev branch, thank you, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
Broken unordered list.
What does this PR change?
Fix broken unordered list.
Is this change appropriate for the core library?
Yes
What alternatives did you consider?
I have just fixed typo in the obvious way.
Does this PR contain multiple unrelated changes?
No
Existing PRs
No, it is simple typo easy to fix.
Environment tested
No
New harness support (required if this PR adds a new harness)
No
Evaluation
No
Rigor
superpowers:writing-skillsandcompleted adversarial pressure testing (paste results below)
rationalizations, "human partner" language) without extensive evals
showing the change is an improvement
Human review