test(skill-triggering): add pipefail so failed tests fail run-all.sh#1493
Open
Nandakumar-M wants to merge 1 commit into
Open
test(skill-triggering): add pipefail so failed tests fail run-all.sh#1493Nandakumar-M wants to merge 1 commit into
Nandakumar-M wants to merge 1 commit into
Conversation
run-all.sh used `if cmd | tee log; then` to record per-skill output. Without `pipefail`, the pipeline's exit status is tee's (always 0), so failed tests were rolled up as passed in the summary. Adding `set -eo pipefail` makes the pipeline fail when run-test.sh fails, which propagates to the if/else and into the PASSED/FAILED counters. Verified: `bash -c 'set -e; if false | tee /dev/null; then echo PASS; else echo FAIL; fi'` prints PASS; with `set -eo pipefail` it prints FAIL. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an issue with
run-all.sh. If any of therun-test.shfailed, run-all.sh still showed all tests passed.run-all.sh used
if cmd | tee log; thento record per-skill output. Withoutpipefail, the pipeline's exit status is tee's (always 0), so failed tests were rolled up as passed in the summary.Adding
set -eo pipefailmakes the pipeline fail when run-test.sh fails, which propagates to the if/else and into the PASSED/FAILED counters.