Add missing post-action verification to two skills#626
Add missing post-action verification to two skills#626
Conversation
…spatching-parallel-agents finishing-a-development-branch Option 2 (Push + PR) had no confirmation that the push and PR creation actually succeeded. Added git log and gh pr view checks after the push/create sequence. dispatching-parallel-agents listed 'run full suite' as a bullet point in the Verification section but didn't mark it as a hard gate. Agents could return with conflicting changes and the skill gave no clear signal to stop if the suite failed. Made the requirement explicit with a blocking condition.
📝 WalkthroughWalkthroughTwo skill documentation files have been updated with stricter verification protocols: one adds mandatory multi-step post-agent verification with explicit failure handling for parallel agent dispatching, while the other introduces push and PR creation confirmation steps for branch finishing workflows. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
skills/finishing-a-development-branch/SKILL.md (1)
95-96: Consider adding failure handling guidance for push verification.The verification command
git log origin/<feature-branch> -1 --onelinewill confirm the push succeeded, but there's no explicit instruction on what to do if this command fails (e.g., branch not found on remote). While the command itself is correct, adding a brief note about stopping and investigating if the verification fails would make the workflow more robust.📋 Suggested enhancement to add failure handling
# Verify push succeeded git log origin/<feature-branch> -1 --oneline + +# If verification fails, stop and check push errors before proceeding🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/finishing-a-development-branch/SKILL.md` around lines 95 - 96, Add explicit failure-handling guidance for the verification step that uses `git log origin/<feature-branch> -1 --oneline`: instruct the user that if the command returns no result or errors (branch not found), they should abort further steps, run `git fetch` and re-check remote refs, confirm the push command used (e.g., `git push origin HEAD:<feature-branch>`), and resolve remote branch or permission issues before proceeding; include this note immediately after the `git log origin/<feature-branch> -1 --oneline` line in SKILL.md so readers know to stop and investigate on failure.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@skills/finishing-a-development-branch/SKILL.md`:
- Around line 95-96: Add explicit failure-handling guidance for the verification
step that uses `git log origin/<feature-branch> -1 --oneline`: instruct the user
that if the command returns no result or errors (branch not found), they should
abort further steps, run `git fetch` and re-check remote refs, confirm the push
command used (e.g., `git push origin HEAD:<feature-branch>`), and resolve remote
branch or permission issues before proceeding; include this note immediately
after the `git log origin/<feature-branch> -1 --oneline` line in SKILL.md so
readers know to stop and investigate on failure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f20dc9ff-143b-43d0-b1c2-f4ae7672a74e
📒 Files selected for processing (2)
skills/dispatching-parallel-agents/SKILL.mdskills/finishing-a-development-branch/SKILL.md
While working through the workflow, I noticed two skills that complete irreversible or hard-to-reverse actions without confirming the outcome.
finishing-a-development-branch — Option 2
After
git pushandgh pr create, the skill moves straight to worktree cleanup with no confirmation that either operation succeeded. A failed push (e.g. rejected by remote) or a malformedgh pr createcall would go unnoticed.Added two verification steps after the push/create sequence:
git log origin/<branch> -1 --oneline— confirms the push landedgh pr view --json url,title,state— confirms the PR was createdAlso added to Red Flags: "Assume push/PR succeeded without checking" and to Always: "Confirm PR was created with
gh pr viewafter Option 2".dispatching-parallel-agents — Integration verification
The Verification section listed "Run full suite" as bullet point 3 of 4, at the same visual weight as "Spot check". Nothing indicated it was a blocking condition — an agent could read past it and report completion after just reviewing summaries.
Made the requirement unambiguous: added a bash block showing the command, and an explicit stop condition if the suite fails. Added "Never report integration complete without step 3 output in hand."
Both changes are minimal and follow the existing style of the skills.