Refine receiving-code-review guidance for subagent review feedback#627
Refine receiving-code-review guidance for subagent review feedback#627stablegenius49 wants to merge 1 commit intoobra:mainfrom
Conversation
📝 WalkthroughWalkthroughDocumentation update to the code-review receiving skill that adds structured guidance for handling subagent-generated reviews, introducing a quote-classify-verify-respond workflow with explicit disposition tracking (FIXED, DISAGREE, NEEDS CLARIFICATION). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/receiving-code-review/SKILL.md`:
- Around line 91-103: The fenced code block that begins with "FOR each subagent
finding:" needs a language annotation to satisfy MD040; update the fence by
adding a language token (e.g., change ``` to ```text) so the block is explicitly
marked as a text code block, leaving the block contents unchanged; locate the
fenced block containing the exact "FOR each subagent finding:" lines and modify
only the opening backticks to include the language.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c915d67a-5843-4b7a-bc99-58ed7daa8f7c
📒 Files selected for processing (1)
skills/receiving-code-review/SKILL.md
| ``` | ||
| FOR each subagent finding: | ||
| 1. Quote the exact finding in your own words | ||
| 2. Classify it: spec mismatch / code-quality / test gap / false positive | ||
| 3. Verify against plan + code before changing anything | ||
| 4. Respond with concrete disposition: | ||
| - FIXED: what changed + where | ||
| - DISAGREE: technical reason + evidence | ||
| - NEEDS CLARIFICATION: exact question | ||
|
|
||
| NEVER dismiss findings with vague language like: | ||
| "not a big problem" / "looks fine" / "excellent discovery" (without action) | ||
| ``` |
There was a problem hiding this comment.
Add a language to this fenced block.
Line 91 currently violates MD040, so this section will keep failing markdownlint until the fence is annotated.
Suggested fix
-```
+```text
FOR each subagent finding:
1. Quote the exact finding in your own words
2. Classify it: spec mismatch / code-quality / test gap / false positive
3. Verify against plan + code before changing anything
4. Respond with concrete disposition:
- FIXED: what changed + where
- DISAGREE: technical reason + evidence
- NEEDS CLARIFICATION: exact question
NEVER dismiss findings with vague language like:
"not a big problem" / "looks fine" / "excellent discovery" (without action)</details>
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.21.0)</summary>
[warning] 91-91: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against the current code and only fix it if needed.
In @skills/receiving-code-review/SKILL.md around lines 91 - 103, The fenced code
block that begins with "FOR each subagent finding:" needs a language annotation
to satisfy MD040; update the fence by adding a language token (e.g., change totext) so the block is explicitly marked as a text code block, leaving the
block contents unchanged; locate the fenced block containing the exact "FOR each
subagent finding:" lines and modify only the opening backticks to include the
language.
</details>
<!-- fingerprinting:phantom:triton:grasshopper -->
<!-- This is an auto-generated comment by CodeRabbit -->
Summary
receiving-code-reviewtrigger description to explicitly include subagent/spec-review feedbackValidation
python3frontmatter parse check forskills/receiving-code-review/SKILL.mdCloses #593