feat(finishing-branch): add issue-closing keywords to PR template#657
Open
feat(finishing-branch): add issue-closing keywords to PR template#657
Conversation
The OpenCode plugin maps TodoWrite to 'update_plan', but OpenCode's built-in todo tool is called 'todowrite'. This mismatch causes superpowers skills relying on TodoWrite to behave unreliably. Also updates the same incorrect mapping in INSTALL.md and docs/README.opencode.md. Fixes obra#654 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The skill now prompts the agent to check for related GitHub issues and include closing keywords (Closes #NNN) in the PR body. This enables automatic issue closure on merge instead of requiring manual cleanup. Fixes obra#600 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated three OpenCode mappings changing TodoWrite from Changes
Sequence Diagram(s)sequenceDiagram
participant User as User/Agent
participant Checker as Issue Checker
participant PRGen as PR Body Generator
participant GitHub as GitHub
User->>Checker: Start pre-PR workflow
Checker->>Checker: Parse branch name for issue numbers
Checker->>Checker: Scan commit messages for issue references
Checker->>Checker: Inspect plan/task descriptions for issue links
alt Issue(s) Found
Checker->>PRGen: Provide detected issue number(s)
PRGen->>PRGen: Append per-issue closing lines (e.g., "Closes `#NNN`")
else No Issues Found
Checker->>PRGen: No related issues detected
PRGen->>PRGen: Generate PR body without closing lines
end
PRGen->>User: Present PR body template
User->>GitHub: Create PR (includes closing keywords if present)
GitHub->>GitHub: Auto-close linked issues on merge (if applicable)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/finishing-a-development-branch/SKILL.md`:
- Around line 91-96: Update the "Check for related GitHub issues" guidance in
SKILL.md to explicitly instruct contributors to only add closing keywords for
issues the PR actually resolves (not for incidental references in branch names
or commits); change the bullet that says "If a related issue is found, include a
closing keyword (`Closes `#NNN``) in the PR body" to clarify that you should
verify the PR content mentions the issue as fixed and only add `Closes `#NNN`` for
those confirmed fixes (do not auto-close issues found only as incidental
references like `#654`), and add a short example or note showing correct usage
(e.g., include `Closes `#600`` only when the PR description documents the fix for
`#600`).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d5d1c39c-ad1d-4638-ad51-a0d3a71808f5
📒 Files selected for processing (4)
.opencode/INSTALL.md.opencode/plugins/superpowers.jsdocs/README.opencode.mdskills/finishing-a-development-branch/SKILL.md
… issues only Prevents agents from auto-closing unrelated issues referenced incidentally in branch names or commit messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finishing-a-development-branchskill to check for related GitHub issuesCloses #NNN) in the PR bodyFixes #600
This contribution was developed with AI assistance (Claude Code).