Prevent code blocks and file paths in brainstorming design docs#671
Prevent code blocks and file paths in brainstorming design docs#671pratyush618 wants to merge 1 commit intoobra:mainfrom
Conversation
Design docs should focus on architecture and rationale, not implementation details. Code snippets and file paths belong in the writing-plans output, not the design doc.
📝 WalkthroughWalkthroughTwo policy lines were added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
skills/brainstorming/SKILL.md (1)
86-86: Minor wording inconsistency: "file paths" vs "specific file paths".Line 86 states "No code blocks or file paths" while line 109 says "must not contain code blocks or specific file paths." The addition of "specific" in line 109 could be interpreted to mean that general or non-specific file paths are acceptable, which likely isn't the intent.
Consider using consistent wording in both places. Options:
- Use "file paths" in both (simpler, matches line 86)
- Use "specific file paths" in both (emphasizes the concern about exact paths going stale)
♻️ Option 1: Remove "specific" for consistency
-- **Design docs must not contain code blocks or specific file paths.** Keep them focused on ideas, architecture, component descriptions, data flow, trade-offs, and success criteria. Implementation details go in the writing-plans output, not here. +- **Design docs must not contain code blocks or file paths.** Keep them focused on ideas, architecture, component descriptions, data flow, trade-offs, and success criteria. Implementation details go in the writing-plans output, not here.♻️ Option 2: Add "specific" to line 86 for consistency
-- **No code blocks or file paths** — design docs describe ideas and architecture, not implementation. Code snippets and specific file paths belong in the implementation plan (writing-plans), not the design doc. File paths in design docs go stale when files are moved. +- **No code blocks or specific file paths** — design docs describe ideas and architecture, not implementation. Code snippets and specific file paths belong in the implementation plan (writing-plans), not the design doc. File paths in design docs go stale when files are moved.Also applies to: 109-109
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/brainstorming/SKILL.md` at line 86, Update the wording for consistency between the two rules by choosing one phrase and applying it in both places: replace "No code blocks or file paths" (the current phrase on the earlier rule) or "must not contain code blocks or specific file paths" (the later rule) so both use the same terminology; either use "file paths" in both lines or "specific file paths" in both lines to remove ambiguity and ensure uniform guidance across the document.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@skills/brainstorming/SKILL.md`:
- Line 86: Update the wording for consistency between the two rules by choosing
one phrase and applying it in both places: replace "No code blocks or file
paths" (the current phrase on the earlier rule) or "must not contain code blocks
or specific file paths" (the later rule) so both use the same terminology;
either use "file paths" in both lines or "specific file paths" in both lines to
remove ambiguity and ensure uniform guidance across the document.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 81e2df07-a17a-4ce0-a1a2-8eab3117eceb
📒 Files selected for processing (1)
skills/brainstorming/SKILL.md
Fixes #649
Summary
writing-plansoutput, and file paths go stale when files are moved