feat: Allow for custom endpoints in chronicleexporter/http_exporter #2167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing Config.Location if it's not set
dpaasman00
requested changes
Feb 18, 2025
Comment on lines
-140
to
-141
| if cfg.Location == "" { | ||
| return errors.New("location is required when protocol is https") |
There was a problem hiding this comment.
I think this is still required because this parameter is used for every log that's sent in the constructed forwarder string. We'll probably need a different way/new parameter to indicate a custom endpoint. https://github.com/observIQ/bindplane-otel-collector/blob/main/exporter/chronicleexporter/marshal.go#L532-L535
| @@ -156,6 +156,9 @@ func (exp *httpExporter) uploadToChronicleHTTP(ctx context.Context, logs *api.Im | |||
| // URL for the request: https://{region}-chronicle.googleapis.com/{version}/projects/{project}/location/{region}/instances/{customerID} | |||
| // Override for testing | |||
| var httpEndpoint = func(cfg *Config, logType string) string { | |||
| if cfg.Location == "" { | |||
| return fmt.Sprintf("https://%s/v1alpha/projects/%s/instances/%s/logTypes/%s/logs:import", cfg.Endpoint, cfg.Project, cfg.CustomerID, logType) | |||
There was a problem hiding this comment.
Do we still require the location value in the URL? Asked Travis about this and he was going to test it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the requirement for Config.Location to be set so that users can use a custom endpoint. If Location is set, we construct the endpoint for backwards compatibility.
Checklist