Skip to content

Improve event edit modal and fix bugs #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0-ft wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve event edit modal and fix bugs #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
acf3075
Add title to event editing modal
0-ft May 18, 2022
f3ad73d
Update event editing modal
0-ft May 18, 2022
f4fba25
Remove erroneous bracket from end of recurring event filenames
0-ft May 18, 2022
bbdb056
Always set end date when event is created
0-ft May 19, 2022
0149920
Always have title for event modal
0-ft May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions src/EditModal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
.ofc-edit-modal-content {
display: grid;
gap: 1em;
grid-template-columns: 1fr 1fr;
}

.ofc-edit-modal-column {
display: flex;
flex-direction: column;
}

.ofc-edit-modal-event-save-button {
Copy link
Copy Markdown
Collaborator

@davish davish May 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the save button could be a primary interactive button here, to make it stand out from the delete button and the open note button?

margin: 0;
}

.ofc-edit-modal-content label {
color: var(--text-muted);
font-size: 14px;
}

.ofc-edit-modal-content input[type="date"],
.ofc-edit-modal-content input[type="time"],
.ofc-edit-modal-content select {
background: var(--background-modifier-form-field);
border: 1px solid var(--background-modifier-border);
color: var(--text-normal);
font-family: inherit;
padding: 5px 14px;
font-size: 16px;
border-radius: 4px;
outline: none;
height: 30px;
}

.ofc-edit-modal-buttons,
.ofc-edit-modal-checkbox {
display: flex;
}

.ofc-edit-modal-event-delete-button {
background-color: var(--background-secondary);
color: var(--background-modifier-error);
border-color: var(--background-modifier-error);
border-width: 1px;
border-style: solid;
margin-right: auto;
}

.not-visible {
display: none;
}
Loading