Conversation
Collaborator
Author
|
Looks like there's a bug where events in daily notes are duplicated in the view when they're moved to a new day. Those old events aren't in the eventstore, and so get "event not found" errors when you then try and modify them. Likely this is something to do with the event ID not propagating through? Will investigate. It's not present on Potentially related to the type changes in the DailyNoteCalendar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #248.
Zod lets us define the type of an
OFCEventand how it's parsed at the same time. As an added bonus, Zod makes it easy to parse values that are stored as strings such asdateandstartinto relevant types during parsing rather than doing it at every callsite where those types are needed. This will make querying on date ranges in #326 easier.OFCEventOFCEventandvalidateEvent().CalendarInfoluxondates and times and add serialization methods that turn them back in to primitive types. Might leave this for another PR.