Use the users local timezone for non recurring ics events#464
Open
JMPJNS wants to merge 2 commits intoobsidian-community:mainfrom
Open
Use the users local timezone for non recurring ics events#464JMPJNS wants to merge 2 commits intoobsidian-community:mainfrom
JMPJNS wants to merge 2 commits intoobsidian-community:mainfrom
Conversation
JMPJNS
changed the title
Suya1671
reviewed
Jul 23, 2023
| import ical from "ical.js"; | ||
| import { OFCEvent, validateEvent } from "../../types"; | ||
| import { DateTime } from "luxon"; | ||
| import { DateTime, DateTimeJSOptions } from "luxon"; |
There was a problem hiding this comment.
why not use an import type here?
Suggested change
| import { DateTime, DateTimeJSOptions } from "luxon"; | |
| import { DateTime, type DateTimeJSOptions } from "luxon"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a potential fix to #311 by parsing non recurring ics events in the users current local timezone