Skip to content

Conversation

@claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented Nov 20, 2024

Types of changes

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)

Description

Remove unused Flatpickr-related code from the Edit Task modal...

This code was all remnants of my unreleased earlier ChatGPT-driven attempt at adding a date-picker calendar widget to the Edit Task modal.

That code could have been disabled in #3067, and was finally totally redundant after #3169.

Motivation and Context

Clean up code.

How has this been tested?

  • Manual exploratory testing in the demo vault.
  • Diffing the new code with the versions prior to adding use of Flatpickr, to confirm I really have removed everything.

Checklist

Terms

@claremacrae claremacrae added the scope: edit task The Create or edit task modal/dialog label Nov 20, 2024
@claremacrae claremacrae changed the title refactor: Remove unused remnants of Flatpickr code from Edit Task modal refactor: Remove unused Flatpickr code from Edit Task modal Nov 20, 2024
@sonarqubecloud
Copy link

@claremacrae claremacrae merged commit c7cafa1 into main Nov 20, 2024
3 checks passed
@claremacrae claremacrae deleted the refactor-remove-old-code branch November 20, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: edit task The Create or edit task modal/dialog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants