refactor: Reduce repetition of parsing of show/hide options #3214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Types of changes
Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)Description
Refactor to reduce repetition in
QueryLayoutOptionsandTaskLayoutComponent.Motivation and Context
To make the code easier to read and to modify.
How has this been tested?
Specifically, I added full tests of the existing code first, and then refactored the original code.
I am conscious that there is now some similarity between code in the tests and the implementation - but the tests came first, to ensure I didn't break the code during refactoring.
Screenshots (if appropriate)
Checklist
yarn run lint.Terms