feat: 'explain' shows effect of Line Continuations & Placeholders #3221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lines and placeholders Partial fix for #2349.
…atement By making the field private
…lines and placeholders Completes the fix for #2349.
This was a copy-and-paste typo in the original code
… as for filters The extra blank line makes the explanations readable with custom sorting and grouping, where the continuation characters and/or placeholders are used.
|
claremacrae
added
the
scope: explain
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
feat- non-breaking change which adds functionality)Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)Description
The explanations of
sort byandgroup bynow reveal any placeholders and continuation lines, making it easier to understand the underlying query.Note that there is one change in behaviour, revealed by a probable typo in an old test...
This:
Used to be explained as:
And is now explained as:
I was not immediately able to see the cause of the change. But decided to accept it, as it makes the
explainoutput better match the underlying text - and also if any users share explanations in GitHub or Discord, the extra characters will at least be visible.Motivation and Context
Fix #2349.
How has this been tested?
Screenshots (if appropriate)
Checklist
yarn run lint.Terms