Skip to content

Conversation

@dangehub
Copy link
Contributor

Types of changes

Changes visible to users:

  • New feature (prefix: feat - non-breaking change which adds functionality)
    • Issue/discussion:
    • WARNING: If the link is absent, the PR may be closed without review, due to the workload that such reviews usually require.
  • Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
    • Issue/discussion:
  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • Documentation (prefix: docs - improvements to any documentation content for users)
  • Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)
  • Contributing Guidelines (prefix: contrib - any improvements to documentation content for contributors - see Contributing to Tasks)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
  • Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Description

Translate the untranslated entries into Chinese and adjust the original Chinese translations.

Motivation and Context

for i18n

How has this been tested?

Standard i18n translation methods should not break the code, so no actual testing was done.

Screenshots (if appropriate)

Checklist

Terms

Copy link
Collaborator

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for doing this, and so quickly.

I see the new translations have been added to en.json - the English version of the plugin.

Sorry, I should have been specific that the Chinese translations go in zh_cn.json, and en.json would not change.

If you like, I can apply your edits from this PR to code on the main branch - and quote you as a co-author.

@claremacrae claremacrae added question Further information is requested scope: internationalisation Translations - Making the plugin work well for non-English-language users - also known as i18n labels Jan 26, 2025
@dangehub
Copy link
Contributor Author

Thank you very much for doing this, and so quickly.

I see the new translations have been added to en.json - the English version of the plugin.

Sorry, I should have been specific that the Chinese translations go in zh_cn.json, and en.json would not change.

If you like, I can apply your edits from this PR to code on the main branch - and quote you as a co-author.

🫣Oops, my bad. I know it should have been under zh-cn, but I messed up when submitting. I've already fixed the file. Could you check it again? Thanks!

@dangehub dangehub closed this Jan 26, 2025
@dangehub dangehub reopened this Jan 26, 2025
@sonarqubecloud
Copy link

@claremacrae claremacrae removed the question Further information is requested label Jan 26, 2025
Copy link
Collaborator

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant. I had ChatGPT convert the new strings back to English and they were all perfect!

Many thanks.

@claremacrae claremacrae changed the title chore: Enhance Chinese Translation i18n: Enhance Chinese Translation Jan 26, 2025
@claremacrae claremacrae merged commit 540acf0 into obsidian-tasks-group:main Jan 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: internationalisation Translations - Making the plugin work well for non-English-language users - also known as i18n

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants