fix: Support line continuations in TQ_extra_instructions & placeholders#3450
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)TQ_extra_instructionsdocsdocs- improvements to any documentation content for users)Internal changes:
test- additions and improvements to unit tests and the smoke tests)Description
Fix a documented limitation that instructions in
TQ_extra_instructionsand in multi-line placeholders did not support line continuations.Motivation and Context
I am addressing limitations in the forthcoming "includes" feature (that is its current working name - I don't yet know what the finale name will be.)
How has this been tested?
Screenshots (if appropriate)
Here is an example Markdown file that now works:
Before, it gave an error:
Now it works:
That used a placeholder, but the same improvements improve the behaviour of
TQ_extra_instructions.Checklist
yarn run lint.Terms