Skip to content

fix: Support line continuations in TQ_extra_instructions & placeholders#3450

Merged
claremacrae merged 1 commit into
mainfrom
fix-continuations-in-placeholders
May 3, 2025
Merged

fix: Support line continuations in TQ_extra_instructions & placeholders#3450
claremacrae merged 1 commit into
mainfrom
fix-continuations-in-placeholders

Conversation

@claremacrae
Copy link
Copy Markdown
Member

@claremacrae claremacrae commented May 3, 2025

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
    • Issue/discussion: None, but it fixes a limitation that was mentioned in the TQ_extra_instructions docs
  • Documentation (prefix: docs - improvements to any documentation content for users)

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Fix a documented limitation that instructions in TQ_extra_instructions and in multi-line placeholders did not support line continuations.

Motivation and Context

I am addressing limitations in the forthcoming "includes" feature (that is its current working name - I don't yet know what the finale name will be.)

How has this been tested?

  • Updating existing unit tests
  • Manual exploratory testing

Screenshots (if appropriate)

Here is an example Markdown file that now works:

---
task_instructions_with_continuation_line: |-
  path \
    includes query_using_properties
---
# Test

```tasks
explain
{{query.file.property('task_instructions_with_continuation_line')}}
```

Before, it gave an error:

image

Now it works:

image

That used a placeholder, but the same improvements improve the behaviour of TQ_extra_instructions.

Checklist

Terms

@claremacrae claremacrae added the scope: scripting Issues to do with custom filters, custom sorting and similar label May 3, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 3, 2025

@claremacrae claremacrae merged commit f239a04 into main May 3, 2025
4 checks passed
@claremacrae claremacrae deleted the fix-continuations-in-placeholders branch May 3, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: scripting Issues to do with custom filters, custom sorting and similar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant