You can now select for the global filter to land at the end of a task#462
Draft
DamnedScholar wants to merge 2 commits into
Draft
You can now select for the global filter to land at the end of a task#462DamnedScholar wants to merge 2 commits into
DamnedScholar wants to merge 2 commits into
Conversation
schemar
requested changes
Jan 2, 2022
Collaborator
schemar
left a comment
schemar
left a comment
There was a problem hiding this comment.
Please remove package-lock.json and use yarn instead. Yarn should also use the existing yarn.lock file where dependencies should have their correct versions.
Collaborator
|
Thank you @DamnedScholar, looks very compact/nice 👍 I don't have much time right now, but I will have a look as soon as I do. |
schemar
reviewed
Jan 5, 2022
Collaborator
schemar
left a comment
schemar
left a comment
There was a problem hiding this comment.
Sorry, I didn’t elaborate on that enough with my last comment. I think if you revert package.json and yarn.lock, then do a yarn install, everything should work. Or is that not the case?
Collaborator
|
@DamnedScholar you still have unrelated changes in your |
7 tasks
Member
|
Setting to draft status any PRs which are not currently mergable, but will be useful in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #147.
I had to update
package.jsonto pin@types/jestto^27.0.0to resolve a dependency conflict on install. Every other change is directly related to the issue fix.