fix: Fix active template highlight#819
Open
yasuharu519 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's happening
Two different visible behaviors that turn out to be the same underlying issue:
Both come from the same problem: when a template is selected, the internal
editingTemplateIndexis updated but the DOM.activeclass on the template list is never re-synced.Fix
updateTemplateListActiveState(templateId)already exists insettings-section-ui.tsfor exactly this purpose, but it is no longer called anywhere.Call it from
showSettingsSectionwhenever the templates section is shown with atemplateId.Since
showTemplateEditor()always ends withshowSettingsSection('templates', editingTemplate.id), this covers all selection paths (click, duplicate, new, delete-then-select-next, import, URL restore, drag-and-drop reorder).Fixes #440