Notion API: Handle nested paragraphs#545
Open
danielgavrilov wants to merge 1 commit into
Open
Conversation
They were getting completely discarded.
Author
|
One thing I'm not sure about: Markdown doesn't really support nesting paragraphs. In Obsidian's Edit mode, the paragraphs appear indented, but not Reading mode (leading whitespace is ignored). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested paragraphs were silently discarded on import. A paragraph indented under another paragraph in Notion (Tab in the editor — the child arrives in the API as a block in the parent's
.childrenwithhas_children: true) would simply vanish from the output.Fix
convertParagraphnow recursively converts its children and emits them below the parent, prefixing each nested level with 4 spaces per depth so the hierarchy is preserved in the Markdown.Example
Before: only "A paragraph with children" made it into the note — both nested paragraphs were dropped.
After: All paragraphs included.