-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add plugin: Notemd #6082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: Notemd #6082
Conversation
Hello!I found the following issues in your plugin submission Errors: ❌ Your PR has the invalid This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3]:The command name should not include the plugin name. [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. [1]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to. [1][2]:You should not cast this, instead use a [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :You should consider limiting the number of Do NOT open a new PR for re-validation. |
I have double-checked the requirements and confirmed the following actions have been completed: Type Casting vs. instanceof: While the specific test mock casting wasn't changed (as instanceof isn't suitable there), the core processing functions (processWithNotemd, processFolderWithNotemd, check-for-duplicates) in main.ts now use instanceof TFile along with file extension checks (.md or .txt) to ensure they operate only on supported text files. The README.md has also been updated to inform users of this limitation. |
Changes requested by bot have been made, ready for additional review by human. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1]:Lookbehinds are not supported in iOS versions before 16.4 [1][2][3][4][5]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. [1][2]:You should not cast this, instead use a [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :You should consider limiting the number of Optional[1][2][3]:Casting to Do NOT open a new PR for re-validation. |
I have addressed the points raised in the PR feedback and subsequent requests: Inline Styles: Moved inline styles for the progress bar in NotemdSidebarView.ts to styles.css using a CSS variable. |
Changes requested by bot have been made, ready for additional review by human. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin:https://github.com/Jacobinwwey/obsidian-NotEMD
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.Description
Notemd enhances your Obsidian workflow by integrating with various Large Language Models (LLMs) to process your notes, automatically generate wiki-links for key concepts, create corresponding concept notes, and perform basic duplicate checks.
AI-Powered Document Processing
Knowledge Graph Enhancement
[[wiki-links]]
to core concepts within your processed notes based on LLM output.Duplicate Detection