Skip to content

Conversation

@ddunnock
Copy link

@ddunnock ddunnock commented Nov 9, 2025

I am submitting a new Community Plugin

  • I attest that I have done my best to deliver a high-quality plugin, am proud of the code I have written, and would recommend it to others. I commit to maintaining the plugin and being responsive to bug reports. If I am no longer able to maintain it, I will make reasonable efforts to find a successor maintainer or withdraw the plugin from the directory.

Repo URL

Link to my plugin: https://github.com/ddunnock/mdx-support

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugin's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template. The PR template can be found here


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ddunnock
Copy link
Author

ddunnock commented Nov 9, 2025

Updated PR description to follow the template format exactly. Ready for validation.

@ddunnock ddunnock closed this Nov 9, 2025
@ddunnock ddunnock reopened this Nov 9, 2025
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Nov 9, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]
Async arrow function 'resolveVideoPath' has no 'await' expression.

[1]
Async arrow function 'resolveImagePath' has no 'await' expression.

[1][2][3][4][5]
Use sentence case for UI text.


Optional


Do NOT open a new PR for re-validation.
Once you have pushed some changes to your repository the bot will rescan within 6 hours
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.
To run these checks locally, install the eslint plugin in your project.
Do NOT rebase this PR, this will be handled by the reviewer once the plugin has been approved.

@ddunnock
Copy link
Author

ddunnock commented Nov 9, 2025

Thank you for the review! I've addressed all the feedback:

Sentence case fixes:

  • Capitalized HTML and MDX acronyms in settings UI text
  • Capitalized dropdown theme options (Auto, Light, Dark)

Async function fixes:

  • Removed async keyword from resolveVideoPath and resolveImagePath functions as they don't use await

All changes have been pushed and the build passes successfully.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2]
Use sentence case for UI text.


Optional


Do NOT open a new PR for re-validation.
Once you have pushed some changes to your repository the bot will rescan within 6 hours
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.
To run these checks locally, install the eslint plugin in your project.
Do NOT rebase this PR, this will be handled by the reviewer once the plugin has been approved.

@ddunnock
Copy link
Author

ddunnock commented Nov 9, 2025

Fixed the remaining sentence case issues - changed 'MDX' back to lowercase 'mdx' in descriptions to match the existing style throughout the settings file. HTML remains uppercase as it's a formal acronym.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Changes requested plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants