[Breaking] Allow full routes for RouteToUrl in obelisk widgets#860
Open
alexfmpe wants to merge 1 commit into
Open
[Breaking] Allow full routes for RouteToUrl in obelisk widgets#860alexfmpe wants to merge 1 commit into
alexfmpe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently no type-safe way to obtain a url for a backend route on frontend widgets. Current workaround is to do
Right validEncoder = checkEncoder fullRouteEncoderon the frontend and userenderBackendRoute.This PR makes
ObeliskWidgetprovideRouteToUrlfor the full route, but breaks backwards compatibility.If only frontend routes are used, apps can simply provide an adapter at the root
but to actually use this for backend routes, one needs to propagate
RouteToUrlconstraints throughout the app, and adjust the arguments of all therouteLinkfamily of widgets. Maybe somelocalequivalent forRouteToUrlwould make the transition smoother by allowing an easy way to gradually rollout the expanded functionality.I have:
developbranchhlint .(lint found code you did not write can be left alone)$(nix-build -A selftest --no-out-link)nix-build release.nix -A build.x86_64-linux --no-out-link(orx86_64-darwinon macOS)