WIP: Deployments refactor#971
Draft
madeline-os wants to merge 19 commits into
Draft
Conversation
- prepare for factored out ob deploy - expose bare nixos module - fix some args passing bugs
alexfmpe
reviewed
Sep 1, 2022
| , uriFragment = "" | ||
| } | ||
| , _encoderImpl_decode = \uri -> | ||
| case (uriScheme uri /= uriScheme baseUri, uriAuthority uri /= uriAuthority baseUri, Data.List.stripPrefix basePath (uriPath uri)) of |
Contributor
There was a problem hiding this comment.
Shouldn't these be == ?
> :set -XFlexibleContexts -XTypeApplications
> let Just uri = Network.URI.parseURI "https://test.test"
> let Right enc = checkEncoder $ pathQueryEncoder uri
> tryDecode enc (encode @(Either Text) enc ("", "")) :: Either Text (String, String)
Left "pathQueryEncodering: wrong base uri; expected https://test.test got https://test.test"
runeksvendsen
force-pushed
the
db-generalised-deployments-rebase
branch
from
d7b2979 to
62f9a3d
Compare
runeksvendsen
force-pushed
the
db-generalised-deployments-rebase
branch
from
62f9a3d to
34aa591
Compare
…m/obsidiansystems/obelisk into db-generalised-deployments-rebase
The initial change in 34aa591 was designed to make it possible to override attributes in serverExe (see, e.g., how nix/test/bench.nix overrides the backend attribute with a profiled executable). This patch fixes some quoting and variable naming issues that crept in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have:
developbranchhlint .(lint found code you did not write can be left alone)$(nix-build -A selftest --no-out-link)nix-build release.nix -A build.x86_64-linux --no-out-link(orx86_64-darwinon macOS)