Skip to content

Require Applicative parse when creating encoders#985

Open
alexfmpe wants to merge 1 commit into
obsidiansystems:developfrom
alexfmpe:require-applicative-parse
Open

Require Applicative parse when creating encoders#985
alexfmpe wants to merge 1 commit into
obsidiansystems:developfrom
alexfmpe:require-applicative-parse

Conversation

@alexfmpe
Copy link
Copy Markdown
Contributor

#984 required me to state a law in terms of Applicative parse within a function that doesn't actually have that constraint. It turns out EncoderImpl itself has that awkwardness. One way of addressing that is to require Applicative (and thus pure) to exist when constructing such values.

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant