Skip to content

Conversation

@anodium
Copy link
Contributor

@anodium anodium commented May 31, 2017

Added a distutils setup.py script, allowing the repository to be installed as a package via pip.

@obskyr
Copy link
Owner

obskyr commented May 31, 2017

Ah, sorry, one of the goals of this script is to be as simple as possible for people who aren't familiar with Python, which includes being only one file. Eliminates confusion and all that. That's also why the package installation is part of the script itself, which otherwise would be a fairly strange thing to do.

If were to put it on PyPI, I'd do it in conjunction with a download link in the readme and usage of GitHub's "releases" feature. Even that might be a bit much, though, I don't know. 🤔

In any case, thank you ☆☆☆ for the interest! Really appreciated.

@anodium
Copy link
Contributor Author

anodium commented May 31, 2017

That makes so much sense! I was wondering for so long why the script installed its own dependencies... 😄

But, I'm going to have to respectfully disagree due to github.com:mitsuhiko/pipsi being almost painless to use and manage. In fact, it's the very reason I wrote the setup script, since you can ask pip (and therefore pipsi) to install directly from a git repository. It even handles automatically upgrading the package as new commits are pushed, like any other package you'd find on the PyPI.

Even if the script were included, you mention in the readme to use khinsider.py explicitly multiple times. If someone didn't know what to do at that point, it wouldn't be your burden to carry, as they very obviously ignored the text designed specifically to show them how to use it.

Add requirements.txt

Fix things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants