win-mf: Reintroduce win-mf plugin for Media Foundation-based encoding on WoA #11993
Conversation
WizardCM
added
Seeking Testers
thirumalai-qcom
force-pushed
the
mft-support
branch
2 times, most recently
from
55aa652 to
ea69f55
Compare
There was a problem hiding this comment.
I'm wary about just reintroducing the old code as-is, particularly as we have progressed to C++17 and expect modern C++ coding practices, including but not limited to:
- Use of anonymous namespaces instead of
staticfunctions is deprecated in C++ (static functions are only used for class methods in modern C++). - Use of
constexpras it's preferable over macros in almost all situations as they enable the compiler to optimise code better and sometimes resolve entire code paths at compile time - Abuse of macros instead of functions marked as
constexpr(see above) which makes the code harder to debug
Just merging this would mean re-importing the code smell as well and I just don't see someone else volunteering to "refactor" it after it's been merged again.
plugins/win-mf/CMakeLists.txt
Outdated
There was a problem hiding this comment.
This file should be adapted to current CMake guidelines instead of copied-over from the legacy variant.
| @@ -88,3 +88,4 @@ add_obs_plugin(vlc-video WITH_MESSAGE) | |||
| add_obs_plugin(win-capture PLATFORMS WINDOWS) | |||
| add_obs_plugin(win-dshow PLATFORMS WINDOWS) | |||
| add_obs_plugin(win-wasapi PLATFORMS WINDOWS) | |||
| add_obs_plugin(win-mf PLATFORMS WINDOWS ARCHITECTURES ARM64) | |||
There was a problem hiding this comment.
win-mf should appear between win-dshow and win-wasapi, following alphabetical sorting.
There was a problem hiding this comment.
Done, Thanks for pointing that out.
plugins/win-mf/data/locale/en-US.ini
Outdated
There was a problem hiding this comment.
I'd advise to only add the en-US language file and have it translated again.
@RytoEX WDYT?
|
I tested this on my Snapdragon X laptop and it does work as expected. But Ideally this plugin should be either rewritten from the ground up, or replaced wholesale with just using the FFmpeg implemenation. At the very least, the AAC encoder could probably be removed. Of course since this is ancient it also doesn't support AV1 (which the X Elite chips do support). Aside from what Pat mentioned, the naming also conflicts with #10471 right now. |
plugins/win-mf/mf-aac.cpp
Outdated
| obs_encoder_info info = {}; | ||
| info.id = "mf_aac"; | ||
| info.type = OBS_ENCODER_AUDIO; | ||
| info.codec = "AAC"; |
There was a problem hiding this comment.
Code name needs to be lowercase.
There was a problem hiding this comment.
Done, thanks for pointing that out.
This commit re-introduces the base files required for Media Foundation Transform (MFT) support in the win-mf plugin, specifically targeting Windows on ARM (WoA) devices with Qualcomm hardware. It includes core implementation files, language configuration files for localization, and the initial CMakeLists.txt for integration.
This commit introduces H264 encoder support using the Media Foundation Transform (MFT) interface, specifically targeting Windows on ARM (WoA) devices with Qualcomm hardware. It adds mf-h264.cpp and mf-h264-encoder.cpp/.hpp to implement the encoding logic. Additionally, CMakeLists.txt is updated to include the new source and header files for proper integration into the win-mf plugin.
This commit introduces HEVC encoder support using the Media Foundation Transform (MFT) interface, specifically targeting Windows on ARM (WoA) devices with Qualcomm hardware. It adds mf-hevc.cpp and mf-hevc-encoder.cpp/.hpp to implement the encoding logic. Additionally, CMakeLists.txt is updated to include the new source and header files for proper integration into the win-mf plugin.
This commit introduces AAC encoder support using the Media Foundation Transform (MFT) interface, specifically targeting Windows on ARM (WoA) devices with Qualcomm hardware. It adds mf-aac.cpp and mf-aac-encoder.cpp/.hpp to implement the encoding logic. Additionally, CMakeLists.txt is updated to include the new source and header files for proper integration into the win-mf plugin
This commit updates the CMakeLists.txt file in the plugins directory to incorporate the win-mf plugin into the OBS build system. This change ensures that Media Foundation-based encoding is available for Windows on ARM (WoA) devices, utilizing Qualcomm hardware for efficient video Encoding.
thirumalai-qcom
force-pushed
the
mft-support
branch
from
ea69f55 to
109de95
Compare
|
Will this work with my older Surface Pro X (SQ2)? If it works I can help test it. |
Description
This PR re-introduces the win-mf plugin to OBS Studio, enabling Media Foundation-based encoding for H264, HEVC, and AAC. This plugin was previously removed in PR #7372 but is now being restored to support hardware-accelerated encoding on Windows on ARM (WoA) devices, specifically those utilizing Qualcomm hardware encoders. The Key changes include:
Motivation and Context
The primary motivation for these changes is to enable hardware-accelerated encoding on Windows on ARM (WoA) devices by reintroducing the win-mf plugin in OBS Studio. With the growing adoption of WoA devices, ensuring OBS Studio can leverage hardware encoders on this platform improves performance and efficiency, reducing CPU load while maintaining high-quality encoding.
By integrating the win-mf plugin back into the build system, we enable native support for Media Foundation-based encoding on WoA, ensuring users on this platform can leverage hardware acceleration for streaming and recording. This change ensures better utilization of Qualcomm hardware encoders, providing a more efficient and optimized encoding experience.
How Has This Been Tested?
The changes have been tested by building OBS Studio on a Windows on ARM (WoA) device with Qualcomm hardware. The build completed successfully, and basic functionality tests confirmed that OBS Studio runs as expected with the reintroduced win-mf plugin. Media Foundation-based encoding for H264, HEVC, and AAC was verified to function correctly, ensuring proper hardware acceleration on WoA devices utilizing Qualcomm hardware.
Types of changes
Checklist: