frontend: Allow 5 multitrack reconnect attempts before re-running GCC #11997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warchamp7
previously requested changes
Mar 24, 2025
dsaedtler
force-pushed
the
rodney/mt-reconnect-tweaks
branch
from
b99c569 to
6ef9c1e
Compare
RytoEX
requested changes
Apr 2, 2025
dsaedtler
force-pushed
the
rodney/mt-reconnect-tweaks
branch
from
6ef9c1e to
3fcd37b
Compare
RytoEX
requested changes
Apr 25, 2025
dsaedtler
force-pushed
the
rodney/mt-reconnect-tweaks
branch
from
3fcd37b to
8ec259a
Compare
dsaedtler
force-pushed
the
rodney/mt-reconnect-tweaks
branch
from
8ec259a to
94d5d68
Compare
RytoEX
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a counter to allow up to 5 reconnect failures with the "invalid key" status code before actually giving up.
Motivation and Context
Rather than fully resetting the output, we should try a few more times to wait out any server-side timeouts. If the stream key is still unavailable after 5 attempts (~50 seconds) this will fall back to re-running the full API flow to obtain a new stream key, and possibly different configuration.
How Has This Been Tested?
Locally. Ideally could use a 48 hour test still.
Types of changes
Checklist: