Skip to content

frontend: Allow 5 multitrack reconnect attempts before re-running GCC #11997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsaedtler
Copy link
Contributor

Description

Adds a counter to allow up to 5 reconnect failures with the "invalid key" status code before actually giving up.

Motivation and Context

Rather than fully resetting the output, we should try a few more times to wait out any server-side timeouts. If the stream key is still unavailable after 5 attempts (~50 seconds) this will fall back to re-running the full API flow to obtain a new stream key, and possibly different configuration.

How Has This Been Tested?

Locally. Ideally could use a 48 hour test still.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@dsaedtler dsaedtler force-pushed the rodney/mt-reconnect-tweaks branch from b99c569 to 6ef9c1e Compare March 24, 2025 23:54
@RytoEX RytoEX requested a review from Warchamp7 April 2, 2025 16:51
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a stray file here not meant to be included.

@dsaedtler dsaedtler force-pushed the rodney/mt-reconnect-tweaks branch from 6ef9c1e to 3fcd37b Compare April 2, 2025 17:06
@WizardCM WizardCM added the Enhancement Improvement to existing functionality label Apr 6, 2025
@dsaedtler dsaedtler force-pushed the rodney/mt-reconnect-tweaks branch from 3fcd37b to 8ec259a Compare April 29, 2025 12:21
@dsaedtler dsaedtler requested a review from RytoEX April 29, 2025 12:21
@dsaedtler dsaedtler force-pushed the rodney/mt-reconnect-tweaks branch from 8ec259a to 94d5d68 Compare April 29, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants