Skip to content

frontend: Add dedicated translation of remaining time #12017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

norihiro
Copy link
Contributor

@norihiro norihiro commented Mar 31, 2025

Description

This PR adds a dedicated translation for the remaining time of the disk space in the stats window.

Motivation and Context

I want to remove , from the remaining time when the locale is Japanese.

How Has This Been Tested?

English Japanese
master screenshot-master-en_US screenshot-master-ja_JP
this PR screenshot-mod-en_US screenshot-mod-ja_JP

In my workspace, added a line below to ja-JP.ini and tested.

Basic.Stats.DiskFullIn.Text="%1 時間 %2 分"
  • Checked the format of the remaining time does not change in US English.
  • Checked the text in Japanese does not contain the comma , .

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Enhancement Improvement to existing functionality label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants