Skip to content

Conversation

@iameli
Copy link

@iameli iameli commented Apr 5, 2025

Description

Motivation and Context

We're making Streamplace, live video on Bluesky's AT Protocol! We were in a TechCrunch article last week woo! We're aiming to build a decentralized alternative to Twitch.

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Sean-Der
Copy link
Contributor

Sean-Der commented Apr 6, 2025

So exciting! When this lands we should get more WHIP services in

@WizardCM
Copy link
Member

WizardCM commented Apr 6, 2025

The new service and the bug fix in this PR should be reviewed independently. Please split them into separate PRs.

@iameli iameli changed the title rtmp-services: add Streamplace and unbreak WHIP services rtmp-services: add Streamplace Apr 6, 2025
@iameli
Copy link
Author

iameli commented Apr 6, 2025

@WizardCM Certainly — this PR now adds Streamplace, #12033 fixes support for WHIP services.

@WizardCM WizardCM added the Services These are modifications to the Service list and are not tied to the release schedule label Apr 6, 2025
@gxalpha
Copy link
Member

gxalpha commented Apr 7, 2025

Converting to draft to prevent accidental merges as per the description:

@gxalpha gxalpha marked this pull request as draft April 7, 2025 12:23
@Fenrirthviti
Copy link
Member

Unfortunately, after two weeks of monitoring this does not meet our minimum adoption requirements for being listed in the main services list.

Please feel free to resubmit once this has gained more momentum.

@iameli
Copy link
Author

iameli commented Apr 19, 2025

Unfortunately, after two weeks of monitoring this does not meet our minimum adoption requirements for being listed in the main services list.

Please feel free to resubmit once this has gained more momentum.

@Fenrirthviti Alright, though this PR never made it out of the draft stage. Could we keep this open as a draft until we're ready to submit? That guide says:

You may submit a PR in draft stage before release for review and to accelerate merge once your service becomes available

@Fenrirthviti
Copy link
Member

I'd prefer not to keep a draft open for a service that is currently showing no adoption, as it implies it is still under consideration to be merged. It was my understanding this was marked draft because it was pending a separate fix (which is still pending, but something that we are interested in fixing), not because the service wasn't launched.

Once there is a level of adoption that warrants inclusion in OBS as a listed service, we can either re-open this or you can submit a new PR.

@iameli iameli mentioned this pull request Sep 23, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Services These are modifications to the Service list and are not tied to the release schedule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants