Skip to content

obs-qsv11: Cast width*height to fix sign-compare warning #12114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/obs-qsv11/QSV_Encoder_Internal.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ mfxStatus QSV_Encoder_Internal::InitParams(qsv_param_t *pParams, enum qsv_codec

constexpr uint32_t pixelcount_4k = 3840 * 2160;
/* If size is 4K+, set tile columns per frame to 2. */
if (codec == QSV_CODEC_AV1 && (pParams->nWidth * pParams->nHeight) >= pixelcount_4k) {
if (codec == QSV_CODEC_AV1 && static_cast<uint32_t>(pParams->nWidth * pParams->nHeight) >= pixelcount_4k) {
memset(&m_ExtAv1TileParam, 0, sizeof(m_ExtAv1TileParam));
m_ExtAv1TileParam.Header.BufferId = MFX_EXTBUFF_AV1_TILE_PARAM;
m_ExtAv1TileParam.Header.BufferSz = sizeof(m_ExtAv1TileParam);
Expand Down
Loading