Skip to content

linux-pipewire: Fix camera framerate listing#12779

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
tytan652:fix_pw_camera_fps_list
Jan 23, 2026
Merged

linux-pipewire: Fix camera framerate listing#12779
RytoEX merged 1 commit into
obsproject:masterfrom
tytan652:fix_pw_camera_fps_list

Conversation

@tytan652

@tytan652 tytan652 commented Oct 31, 2025

Copy link
Copy Markdown
Collaborator

Description

The SPA format (pixelformat) was compared with a libobs video format value.

Also removes the SPA format support check since at this point it already has been done while listing formats.

Motivation and Context

Fix a old oops-y (since the source addition)

How Has This Been Tested?

Untested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

The SPA format (pixelformat) was compared with a libobs video format
value.

Also removes the SPA format support check since at this point it already
has been done while listing formats.
@tytan652 tytan652 added kind/bug Categorizes issue or PR as related to a bug. platform/linux Categorizes issue or PR as affecting Linux specifically labels Oct 31, 2025
@dimtpap

dimtpap commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

I ran into this when working on #11371 and can confirm it was causing some formats to list no framerates, at least before the unified FPS/resolution menu refactor, and this was the fix.

@GeorgesStavracas GeorgesStavracas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@RytoEX RytoEX self-assigned this Jan 23, 2026
@RytoEX RytoEX added this to the OBS Studio 32.1 milestone Jan 23, 2026
@RytoEX RytoEX merged commit 0d1f61b into obsproject:master Jan 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. platform/linux Categorizes issue or PR as affecting Linux specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants