linux-pipewire: Defer screencast portal init until source is shown#13157
Open
avafloww wants to merge 1 commit intoobsproject:masterfrom
Open
linux-pipewire: Defer screencast portal init until source is shown#13157avafloww wants to merge 1 commit intoobsproject:masterfrom
avafloww wants to merge 1 commit intoobsproject:masterfrom
Conversation
The previous behaviour would attempt screencast portal initialization even when the source is not shown, which can cause a flood of pop-ups, each indistinguishable from each other, on startup. This commit defers portal init until the first time the source is shown, so the user isn't flooded with pop-ups when starting OBS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous behaviour would attempt screencast portal initialization even when the source is not shown, which can cause a flood of pop-ups, each indistinguishable from each other, on startup.
This commit defers portal init until the first time the source is shown, so the user isn't flooded with pop-ups when starting OBS.
Motivation and Context
This change addresses the ideas.obsproject.com post found here: https://ideas.obsproject.com/posts/2318/do-not-open-screen-sharing-portals-on-startup
On KDE Wayland, all screencast portal requests open as a separate window, with no further information on which source the request belongs to. In setups with many capture sources across multiple scenes, this can easily result in 10-20+ picker windows all opening at startup, with no way to differentiate them.
How Has This Been Tested?
I built the OBS Flatpak with my code changes and tested it.
The screencast portal opens correctly when sources are shown, and the source shows correctly once a window is confirmed via the portal.
Types of changes
Checklist: