libobs: Add module version number to Windows crash handler#13190
Open
exeldro wants to merge 1 commit intoobsproject:masterfrom
Open
libobs: Add module version number to Windows crash handler#13190exeldro wants to merge 1 commit intoobsproject:masterfrom
exeldro wants to merge 1 commit intoobsproject:masterfrom
Conversation
notr1ch
reviewed
Mar 4, 2026
| } | ||
|
|
||
| struct win_version_info ver = {0}; | ||
| if (get_dll_ver(module_name, &ver)) { |
Member
There was a problem hiding this comment.
get_dll_ver calls bmalloc which is unsafe to use in a crashing path (crash could be due to OOM).
Contributor
Author
There was a problem hiding this comment.
The dstr calls in this function also use brealloc, should that all be refactored? And if so that would be something for a separate pull request in my opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add module version number to Windows crash handler
Motivation and Context
Want to know if the users used the latest version to get the crash
example:
00007FFFB8D30000-00007FFFB8D42000 C:\git\obs-studio\build_x64\rundir\RelWithDebInfo\obs-plugins\64bit\3d-effect.dll (0.1.4.0)How Has This Been Tested?
On Windows 11 by crash
Types of changes
Checklist: