-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
UI: Add Manage Scene Collections dialog #8446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9b8c66e
to
9d3f32d
Compare
446d291
to
d88dba5
Compare
c10e2dd
to
6f5235b
Compare
Added Seeking Testers and re-triggered CI to get downloadable artifacts for easier testing. |
Rebased on the updated #8447. With the updated base branch, this should now actually have downloadable build artifacts once CI finishes. |
70af53f
to
011ab97
Compare
31086e3
to
35b77fe
Compare
Co-Authored-By: Warchamp7 <[email protected]>
OBSActionRow already detects buttons and activates them on click. QComboBox is not a QAbstractButton subclass though, so we need custom checks for it. Add that.
Rebased on latest Idian branch. There are a few TODOs still left which I will fix later, plus a conflict to current master but that would require me to rebase the Idian branch as well. |
A filter that emits a doubleClicked signal when the object on which it is installed is double clicked on.
Meant to replace the internal functions inherently coupled to the main window and loaded collection. Some functions are written completely from scratch (e.g. creating a new collection, as before that consisted just of clearing the current scene data and then resaving which meant one would *have* to switch to the new collection) mostly related to actions on scene collections that are not the currently active ones), others partially or largely copied from window-basic-main-scene-collections.
This prevents the menu from getting unreasonably large. Access to older scene collections is preserved through the Manage Scene Collections dialog.
Description
Adds a Scene Collection Manager dialog and moves the scene collection menu to the scenes dock.
Screenshots as of: September 8th, 2023
This solves three major UX problems with current scene collection management:
The new dialog solves these issues. Scene collection that aren't active can now be renamed, duplicated, exported, or deleted. However, the currently active scene collection can no longer be deleted as that would then require switching to some other collection, which can be a bit unpredictable to the user.
It also adds the ability to perform bulk actions on scene collections. This means that it's possible to duplicate, export, or delete multiple scene collections at once.
The collections shown in the menu is now capped at the 10 most recent ones to avoid unreasonably large context menus, other collections can still be switched to by double-clicking them in the dialog.
Driven by a design first approach, based on this mockup. Thanks to @GeorgesStavracas for creating the mockup and to @Warchamp7 for his assistance.
This PR utilizes new widgets by @derrod. It will stay draft until #8447 is merged. However, reviews are still very much desired.
Motivation and Context
See the problems mentioned above.
How Has This Been Tested?
macOS 13.2.1
Tested all new features. This includes:
Types of changes
Checklist: