Skip to content

cmake: Build with Windows file descriptors - #1368

Open
WizardCM wants to merge 1 commit into
obsproject:masterfrom
WizardCM:windows-file-descriptor
Open

WizardCM wants to merge 1 commit into
obsproject:masterfrom
WizardCM:windows-file-descriptor

Conversation

@WizardCM

Copy link
Copy Markdown
Member

Description

Equivelant of obsproject/obs-browser#525

Open to thoughts on whether version should pull from parent repo or not, and exact file description (should it be WebSocket Server module?).

image

Motivation and Context

Unversioned files are unhelpful, and this makes OBS WebSocket consistent with most other DLLs OBS ships with. Potentially useful for tracking crashes using Windows Error Reporting.

How Has This Been Tested?

Tested OS(s): Windows 10

Build and check DLL.

Types of changes

  • Other Enhancement (anything not applicable to what is listed)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant