Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rtk helpers #40

Merged
merged 2 commits into from
May 31, 2024
Merged

fix: rtk helpers #40

merged 2 commits into from
May 31, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented May 31, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


src/helpers/rtkQuery.ts line 180 at r1 (raw file):

export function isTagId(value: unknown): boolean {
  return typeof value === "number" || typeof value === "string";

Do we wanna do something like return ["number", "string"].includes(typeof value) or is that not worth it?

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


src/helpers/rtkQuery.ts line 180 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Do we wanna do something like return ["number", "string"].includes(typeof value) or is that not worth it?

Not worth it in this case, I think

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 3b7c90a into main May 31, 2024
2 checks passed
@SKairinos SKairinos deleted the fix-rtk-helpers-2 branch May 31, 2024 12:58
cfl-bot added a commit that referenced this pull request May 31, 2024
## [1.27.6](v1.27.5...v1.27.6) (2024-05-31)

### Bug Fixes

* import ([9ba872b](9ba872b))
* linting errors ([23fbb17](23fbb17))
* rtk helpers ([#40](#40)) ([3b7c90a](3b7c90a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants