graph500par: add Domain.cpu_relax on failed CAS#3
Open
edwintorok wants to merge 1 commit into
Open
Conversation
This should probably use the `Backoff` module, but for now add at least
one cpu_relax call to avoid spinning needlessly.
This improves both time elapsed and energy usage:
```
sudo perf stat -r 10 -e power/energy-pkg/ -- ./kernel1_run_multicore-runtime -ndomains 32 edges.data`
```
Before:
```
318.40 Joules power/energy-pkg/ ( +- 3.82% )
6.388749432 +- 0.269389879 seconds time elapsed ( +- 4.22% )
```
After:
``` 288.38 Joules power/energy-pkg/ ( +- 5.13% )
5.721849843 +- 0.313571388 seconds time elapsed ( +- 5.48% )
```
Signed-off-by: Edwin Török <edwin@tarides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should probably use the
Backoffmodule, but for now add at least one cpu_relax call to avoid spinning needlessly.This improves both time elapsed and energy usage:
Before:
After:
I've run this on my own machine, would be interesting to see whether the improvement can also be confirmed on the machine that usually runs these benchmarks (
monolith?)