Skip to content

Conversation

@MisterDA
Copy link
Collaborator

@MisterDA MisterDA commented Mar 21, 2025

Network is currently failing?
Close #7.

@Alizter
Copy link
Collaborator

Alizter commented Mar 21, 2025

Let's disable the windows build for now, since we expect it to fail. We can reenable it when we add windows support.

@Alizter
Copy link
Collaborator

Alizter commented Mar 21, 2025

Lwt is an optional dependency which means notty.lwt won't even build so examples/ won't find it.

@Alizter
Copy link
Collaborator

Alizter commented Mar 21, 2025

We should mark lwt as a test dependency in dune-project like (lwt :with-test).


- run: opam install . --deps-only --with-test

- run: opam exec -- dune build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relies on the @default alias which is by default @all. We don't want to build everything in benchmarks/ for instance. To do this have a look at https://dune.readthedocs.io/en/stable/reference/aliases/default.html

We should probably just build src, src-unix and src-lwt for @default.

That is however orthogonal to what we want to do here. We are probably only interested in doing dune build @install which builds an install layout. Afterwards we do dune runtest which is just dune build @runtest.

@kit-ty-kate kit-ty-kate merged commit 0e87169 into master Oct 9, 2025
4 checks passed
@kit-ty-kate
Copy link
Member

Thanks a lot!

@kit-ty-kate kit-ty-kate deleted the gha branch October 9, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

set up continuous integration

4 participants