Improve behaviour regarding unsupported constructs#468
Draft
n-osborne wants to merge 10 commits intoocaml-gospel:mainfrom
Draft
Improve behaviour regarding unsupported constructs#468n-osborne wants to merge 10 commits intoocaml-gospel:mainfrom
n-osborne wants to merge 10 commits intoocaml-gospel:mainfrom
Conversation
Test is positive as the Gospel type checker doesn't fail.
Gospel type checker doesn't fail.
Test is failing, we may want Gospel type checker to ignore the type declaration and emit a simple warning.
The Gospel type checker is failing on the type declaration. If we chose to stop failling on the type declaration, we will have to decide what to do about the specification.
The Gospel type checker is failing, we may want to ignore the type declaration.
Gospel type checker fails on value declaration with a first class module argument. We may want to ignore the value declaration rather than failing when there is no specification attached to it.
This commit makes Gospel type checker stop failling when it encounters an unsupported construct. It also silently ignore the Gospel annotations if any, which is questionable behaviour.
This is a draft, this should print a proper error message with informations about the unsupported construct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft.
The proposed behaviour is to ignore unsupported construct that are not annotated with Gospel specification and fail on the one that are annotated.
This draft implements the behaviour, and is build upon #466 in order to demonstrate the behaviour in the tests.
The failure should be made an informative one (with a real error message).