Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
This is good because there is one less newline, and because it is more consistent with the
@@ functionformatting:There are two issues that need to be addressed before merging:
||, it looks weird:Maybe this is okay. The same weirdness could also happen with
function, even if its less likely.matchis in parens, the code says it shouldnt format like it does, but it still does, with a weird indentation:This is not necessarily bad, but the indentation should be fixed, and why this is happening should be understood before merging.