break-struct for sig fix#2709
Merged
EmileTrotignon merged 2 commits intoMay 14, 2025
Merged
Conversation
Collaborator
Author
|
No changelog because the bug was introduced in #2682 which is still unreleased. |
42a3e18 to
bf3f6a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in my #2682 PR to apply break-struct=natural to
sig ... end.This fixes that bug. The bug was that the box structure did not put the
endon a new line:The implem is a bit hacking, but I tried modifying the box structure to do something cleaner, but it was very hard to do without making diffs all over the place. I can't just copy the
struct ... endboxes because of the following:The code for
struct ... endsimply handles less cases.