Skip to content

Conversation

@Julow
Copy link
Collaborator

@Julow Julow commented Oct 14, 2025

No description provided.

@Julow Julow added the no changelog set this to bypass the CI check for changelog entries label Oct 14, 2025
@Julow Julow merged commit cf3d2e7 into ocaml-ppx:main Oct 14, 2025
10 of 12 checks passed
@MisterDA
Copy link

Note that cmdliner's author explicitly asks not to test the output of cmdliner, as it is subject to change.
https://discuss.ocaml.org/t/reminder-opam-repository-package-tests-do-not-snapshot-test-cmdliners-end-user-outputs/17331/3

I suppose it's fine to promote its output as a man page.

@Julow
Copy link
Collaborator Author

Julow commented Oct 16, 2025

We use cmdliner in a complicated way (we represent options parsed from the config files and env variable as cmdliner Arg/Term). How can we test it otherwise ?
Even if our use is unreasonable, cmdliner allows writing custom converter, with custom errors, and I think it's unreasonable not to test that.

@Julow
Copy link
Collaborator Author

Julow commented Oct 16, 2025

In the meantime, I removed the cmdliner output from tests: #2728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog set this to bypass the CI check for changelog entries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants