ppx_deriving.create: use [Ast_helper.with_default_loc] to derive create function with location info
#297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure what I'm doing, but this seems to fix the following issue for me: ocaml/merlin#1910
Here is a test file:
With this PR, I can use merlin to jump from the derived functions
create,make, etc, to the type declaration with the deriving attribute.Without, I would just get errors like:
merlin-call-locate: 'show' seems to originate from '_none_' whose ML file could not be found.I've made same fix in all included derivers, perhaps in quite a brutish way. Feedback welcome!