Add module bindings and module declarations to deriving #576
+183
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Ferris <[email protected]>
patricoferris
requested review from
ceastlund,
NathanReb,
panglesd and
pitag-ha
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #546 a feature request was made for
[@@deriving ...]to work on module bindings (and perhaps their signature counterpart declarations).Some notes:
[@@deriving]features, derived code is placed after the node, therefore using this with module bindings will not place the code inside the module definition but after it. I think some amount ofincludeing can work around this maybe (on the end user's side)?