fix: specify containing group for defface forms#21
Open
dannywillems wants to merge 2 commits into
Open
Conversation
Byte-compiling caml-mode emits warnings of the form "in defface for FACE: fails to specify containing group" for every face defined without a :group keyword. Add ":group 'languages" to each affected defface so the faces are associated with a customization group. This is the standard fix for the warning and does not change runtime behaviour: the face definitions and their default attributes are unchanged. Affected faces: - camldebug-event, camldebug-underline (camldebug.el) - caml-font-stop-face, caml-font-doccomment-face (caml-font.el) - caml-font-stop-face (caml-font-old.el)
Add a GitHub Actions workflow that byte-compiles all source files with "byte-compile-error-on-warn" enabled, so any new byte-compile warning fails CI. The matrix covers the declared minimum (Emacs 24.4), 30.1, and the development snapshot, using actions/checkout@v5 and purcell/setup-emacs@master. Also add a Dependabot config to keep the GitHub Actions up to date.
Author
|
This is an automated effort to help maintaining packages in the Emacs community. See https://x.com/dwillems42/status/2060720730338185699 and https://dannywillems.github.io/emacs-package-maintenance/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Byte-compiling caml-mode currently emits warnings for every face
defined without a containing customization group:
Fixes (behaviour-preserving)
:group 'languagesto each affected
defface. This associates the faces with acustomization group as required and does not change the face
definitions, their default attributes, or any runtime behaviour.
Affected faces:
camldebug-event,camldebug-underline,caml-font-stop-face,caml-font-doccomment-face.After this change all source files byte-compile with no warnings on
Emacs 24.4 (the declared minimum), 30.1, and the development snapshot.
CI
Adds a GitHub Actions workflow that byte-compiles every source file with
byte-compile-error-on-warnenabled, so any future byte-compile warningfails CI. The matrix covers Emacs 24.4, 30.1, and snapshot, using
actions/checkout@v5andpurcell/setup-emacs@master. A Dependabotconfig keeps the actions up to date.
Residual warnings
None. All byte-compile warnings are resolved.