fix(oxcaml): js_of_ocaml compile whole for parameterised instances #12762
Conversation
art-w
force-pushed
the
instantiate-parameterized-jsoo
branch
from
d15c57b to
bfd327b
Compare
art-w
force-pushed
the
instantiate-parameterized-jsoo
branch
4 times, most recently
from
3b9d28e to
c28e071
Compare
art-w
force-pushed
the
instantiate-parameterized-jsoo
branch
2 times, most recently
from
81a60a9 to
3093ce9
Compare
art-w
force-pushed
the
instantiate-parameterized-jsoo
branch
from
3093ce9 to
129c90d
Compare
| | Not_parameterised -> false | ||
| | Complete | Partial -> true) | ||
| in | ||
| (* jsoo supports only whole program compilation of parameterised instances, |
There was a problem hiding this comment.
Is this limitation permanent or will it be relaxed in a later jsoo version?
There was a problem hiding this comment.
It would be good to know if support is needed inside the jsoo compiler or if one just need to fix the dune rule ..
There was a problem hiding this comment.
I've added some explanations in #12564 (comment) regarding the bytecode error I'm seeing when doing separate compilation in jsoo, so I think it requires an oxcaml-specific patch in jsoo before we can change the dune rules for separate compilation :)
Signed-off-by: Arthur Wendling <[email protected]>
art-w
force-pushed
the
instantiate-parameterized-jsoo
branch
from
129c90d to
44f94d4
Compare
|
I don't really understand the direction taken by this PR. The change proposed here is not discover-able, hard to explain. The user might not even be aware that there are parameterised instances in the cone of dependencies. |
4 participants
Fixes #12564
Follow up on #12561 :
Js_of_ocaml and wasm_of_ocaml don't currently support the incremental compilation of OxCaml parameterised libraries instantiation, so we have to enforce whole program compilation.