Fix/duplicate dependencies warning #12861
Open
+266
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benodiwal
force-pushed
the
fix/duplicate-dependencies-warning
branch
2 times, most recently
from
29f875e to
b11d34d
Compare
rgrinberg
reviewed
Dec 7, 2025
| > (package | ||
| > (name test-pkg) | ||
| > (allow_empty) | ||
| > (depends (ocaml (>= 4.08)) (ocaml (< 5.0)))) |
Member
There was a problem hiding this comment.
The test says that this syntax is valid, but duplicating constraints is also perfectly valid as far as opam is concerned. So I think we should have a better criteria for things to reject rather than just them being accepted by opam.
Personally, I'd reject this form as well because any separate constrains like this can be combined into a single constraint.
Contributor
Author
There was a problem hiding this comment.
Got it. I have added the logic to reject these as well.
benodiwal
force-pushed
the
fix/duplicate-dependencies-warning
branch
3 times, most recently
from
6fd7018 to
4e5af9a
Compare
Signed-off-by: Sachin Beniwal <[email protected]>
Signed-off-by: Sachin Beniwal <[email protected]>
Signed-off-by: Sachin Beniwal <[email protected]>
Signed-off-by: Sachin Beniwal <[email protected]>
Signed-off-by: Sachin Beniwal <[email protected]>
benodiwal
force-pushed
the
fix/duplicate-dependencies-warning
branch
from
4e5af9a to
e8a762a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2678