pkg: rewrite archive extraction with typed tar capabilities #12917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rewrite the extraction capabilities for package management, enforcing the invariants we wish to preserve at the type level. The aim is to separate the concerns of finding an appropriate archive binary, checking the capabilities of this binary, creating arguments for this binary and invoking this for extraction. The public API of extraction is still simple, so the typed invariants are more of an internal impelementation detail. A sumamry of the changes are as follows: - Use GADTs to encode which formats each tar implementation supports, preventing invalid combinations at compile time - Detect tar implementation (BSD/GNU/Other) via --version output - Prefer BSD tar over unzip for zip extraction - Check bsdtar before tar to get more capable implementation - Add gtar to binary list for GNU tar on macOS/BSD - Pass explicit -z/-j flags for OpenBSD/busybox tar Signed-off-by: Ali Caglayan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rewrite the extraction capabilities for package management, enforcing the invariants we wish to preserve at the type level. The aim is to separate the concerns of finding an appropriate archive binary, checking the capabilities of this binary, creating arguments for this binary and invoking this for extraction.
The public API of extraction is still simple, so the typed invariants are more of an internal impelementation detail.
A sumamry of the changes are as follows:
taron OpenBSD #10123