fix(pkg): allow locking relative path outside the workspace#13915
Open
shunueda wants to merge 2 commits intoocaml:mainfrom
Open
fix(pkg): allow locking relative path outside the workspace#13915shunueda wants to merge 2 commits intoocaml:mainfrom
shunueda wants to merge 2 commits intoocaml:mainfrom
Conversation
Signed-off-by: Shun Ueda <me@shu.nu>
shunueda
force-pushed
the
fix/allow-locking-outside-workspace
branch
from
b0de6c6 to
a4bc8cc
Compare
rgrinberg
reviewed
Mar 25, 2026
src/dune_rules/lock_dir.ml
Outdated
| let path = | ||
| Path.of_string_allow_outside_workspace url.path | ||
| |> Path.to_absolute_filename | ||
| |> Path.External.of_string |
Member
There was a problem hiding this comment.
Can't you pattern match on the result of Path.of_string_allow_outside_workspace url.path and construct the right path directly for Fs_memo.path_kind?
Contributor
Author
There was a problem hiding this comment.
Yes, though required some refactoring so I split it into a separate commit.
Signed-off-by: Shun Ueda <me@shu.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10254.
The linked issue has been labeled "bug", and I agree with this as (afaik) Opam allows relative paths outside the workspace, though open to discussion here.