Skip to content

test: enable path tests on windows#14663

Draft
Alizter wants to merge 2 commits into
ocaml:mainfrom
Alizter:push-nnlxvwlypuul
Draft

test: enable path tests on windows#14663
Alizter wants to merge 2 commits into
ocaml:mainfrom
Alizter:push-nnlxvwlypuul

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented May 22, 2026

Alizter added 2 commits May 22, 2026 12:41
…t separators

Replace Filename.concat with External.append_local when stringifying external
build paths with a local suffix. This ensures forward slashes are used on all
platforms, removing the need for conditional Windows/Unix test expectations.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter added the windows Issues that relate to Dune on Microsoft Windows label May 22, 2026
Alizter added a commit that referenced this pull request May 28, 2026
…t separators (#14616)

Replace `Filename.concat` with `External.append_local` when stringifying
external build paths with a local suffix. This ensures forward slashes
are used on all platforms, removing the need for conditional
Windows/Unix test expectations.

- Followup to #14278.
- Followed up by #14663 

- Contributes to #10176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows Issues that relate to Dune on Microsoft Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant